Avoid null reference exception when fetching ReactRootView in bridgeless#47284
Closed
rozele wants to merge 1 commit into
Closed
Avoid null reference exception when fetching ReactRootView in bridgeless#47284rozele wants to merge 1 commit into
rozele wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65141137 |
…ess (facebook#47284) Summary: If the surface hasn't been set up yet, attempting to fetch the ReactRootView will throw a null reference exception. Since the result is already nullable, it's perhaps better to just return null when the surface has not yet been initialized. ## Changelog [Android][Fixed] Avoid null reference exception in bridgeless ReactDelegate Differential Revision: D65141137
rozele
force-pushed
the
export-D65141137
branch
from
21e4584 to
36155d4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65141137 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Oct 29, 2024
…in bridgeless (facebook#47284) Summary: If the surface hasn't been set up yet, attempting to fetch the ReactRootView will throw a null reference exception. Since the result is already nullable, it's perhaps better to just return null when the surface has not yet been initialized. ## Changelog [Android][Fixed] Avoid null reference exception in bridgeless ReactDelegate Differential Revision: D65141137
Contributor
|
This pull request has been merged in 0d66410. |
Collaborator
|
This pull request was successfully merged by @rozele in 0d66410 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
If the surface hasn't been set up yet, attempting to fetch the ReactRootView will throw a null reference exception. Since the result is already nullable, it's perhaps better to just return null when the surface has not yet been initialized.
Changelog
[Android][Fixed] Avoid null reference exception in bridgeless ReactDelegate
Differential Revision: D65141137